Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(python): use rust to convert to/from python datetimes #20660

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bschoenmaeckers
Copy link
Contributor

fixes #16199

Waiting for pyo3 v0.23.4 to be released. PyO3/pyo3#4835

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 89.36170% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.96%. Comparing base (8abd261) to head (45d66f0).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-python/src/conversion/datetime.rs 72.22% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20660      +/-   ##
==========================================
- Coverage   78.97%   78.96%   -0.02%     
==========================================
  Files        1557     1557              
  Lines      220696   220743      +47     
  Branches     2517     2527      +10     
==========================================
+ Hits       174297   174303       +6     
- Misses      45825    45861      +36     
- Partials      574      579       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

delta.num_microseconds().unwrap()
};

Ok(AnyValue::Datetime(timestamp, TimeUnit::Microseconds, None))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this return the timezone info instead of None in the cases where there is one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant