Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow more group_by agg expressions in the new streaming engine #20663

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 10, 2025

This should allow for elementwise combinations of streaming aggregates over elementwise combinations of the input columns.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jan 10, 2025
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 1.37931% with 286 lines in your changes missing coverage. Please review.

Project coverage is 78.86%. Comparing base (c4b704b) to head (35287be).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../polars-stream/src/physical_plan/lower_group_by.rs 0.00% 271 Missing ⚠️
...ates/polars-stream/src/physical_plan/lower_expr.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20663      +/-   ##
==========================================
- Coverage   78.96%   78.86%   -0.10%     
==========================================
  Files        1557     1558       +1     
  Lines      220743   221023     +280     
  Branches     2527     2527              
==========================================
+ Hits       174318   174319       +1     
- Misses      45847    46126     +279     
  Partials      578      578              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants