-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add license header to code files #292
add license header to code files #292
Conversation
.snippets/code/tutorials/polkadot-sdk/parachains/zero-to-hero/build-custom-pallet/src/lib.rs
Outdated
Show resolved
Hide resolved
...utorials/polkadot-sdk/parachains/zero-to-hero/build-custom-pallet/tests/integration_tests.rs
Outdated
Show resolved
Hide resolved
MIT-0 sounds good to me, requesting @albertov19 to also approve from the papermoon side please :) |
@kianenigma @UtkarshBhardwaj007 The repo has a Creative Commons Attribution 4.0 International license. I'm not a legal expert or anything, but I have a couple of comments:
Let me know your thoughts |
|
I remember now that this was the decision made some time ago. MIT is more permissive than CC BY 4.0, the main difference being that CC BY 4.0 requires attribution to the original creator. Broadly speaking, these licenses are compatible. I recommend removing the copyright notice in the code snippets and leaving the license there. Wdyt @kianenigma |
Done. |
SGTM, Agree that:
|
Looks good. I'll let @0xLucca give the final approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
MIT-0
is a variant of the MIT license that removes the attribution requirement, meaning users can use, copy, modify, and distribute the software without needing to include the original copyright notice and permission notice. Since this repository hosts the code used in tutorials, it is meant to be used/distributed by the users of the repository. HenceMIT-0
seems to be a good fit..md
files have been updated to+20
to accomodate for the extra lines used by the license header.mkdocs serve
. For snippets, refer here