[Content migration] - Asset Transfer API #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhussein11
reviewed
Sep 26, 2024
|
|
||
| const assetsApi = new AssetTransferApi(api, specName, safeXcmVersion); | ||
|
|
||
| // Your code using assetsApi goes here |
There was a problem hiding this comment.
Some snippets use assetsApi and other assetApi, stick to one way
Also, I find kind of weird this comment:
// Your code using assetsApi goes here
But is nitpicking at the end of the day, if you find a better way to express it cool, if not no worries :)
There was a problem hiding this comment.
It meant the variable called assetsApi that has already been initialized in line 11. Do you think it looks better if we put assetTransferApi ?
There was a problem hiding this comment.
Yeah, I get that. My point here was that in some snippets, you initialized the variable in a plural form, and in others, you used assetApi in a singular
nhussein11
reviewed
Sep 26, 2024
develop/application-devs/tooling/asset-transfer-api/overview.md
Outdated
Show resolved
Hide resolved
nhussein11
reviewed
Sep 26, 2024
develop/application-devs/tooling/asset-transfer-api/reference.md
Outdated
Show resolved
Hide resolved
nhussein11
reviewed
Sep 26, 2024
nhussein11
reviewed
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates content from the polkadot-ecosystem-docs-draft repository.
Migrated content: