-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore classes that inherit non-synthetic toString #34
Comments
That would be helpful - We just noticed (after updating) that we 'accidentally' relied on #59 - we use better-tostring together with enumeratum - and the upgrade broke all places where enums where looked up via string (as the encapsulating |
We have the exact same problem (b2s + enumeratum). I tried fixing this before, but I couldn't find a reliable way to do this other than generating Currently, the (scala 2) plugin operates right after the compiler's parser, so we don't have any types or even resolved symbols. I tried moving it somewhere else down the pipeline, but it broke more than it fixed :/ |
@mrobakowski for enumeratum you could simply define your own base trait to use instead of |
@carstenlenz yeah, that works (and is in fact better than our current workarounds, so thanks 😄) for enumeratum. However, I would really like this to just work out of the box. I'll try again to mess around with compiler stages because I think we run after the typer in the scala 3 version, so perhaps there is a way to do this properly in scala 2 as well. Unfortunately, my experience with scala compiler plugins is pretty much limited to just this project, so it may take me a while (if it's possible at all). |
|
Given a class that has a
toString
defined in a parent (which isn'tObject
), which isn't thetoString
generated automatically for case classes, we should not define a customtoString
for that class.The text was updated successfully, but these errors were encountered: