Fix #56 #57
Merged
Fix #56 #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubukoz
commented
Jul 11, 2021
| d.name.toString | ||
| def methodNames(clazz: Clazz): List[String] = clazz.impl.body.collect { | ||
| case d: DefDef => d.name.toString | ||
| case d: ValDef => d.name.toString |
There was a problem hiding this comment.
This was added to support override val toString in both Scala versions. A better name for methodNames would be welcome, although memberNames would miss var (which isn't a suitable implementation for toString)
| } | ||
|
|
||
| def isCaseClass(clazz: Clazz): Boolean = clazz.mods.hasFlag(Flags.CASE) | ||
| def isObject(clazz: Clazz): Boolean = clazz.mods.hasFlag(Flags.MODULE) |
There was a problem hiding this comment.
This is added to skip () from case objects.
| @@ -34,7 +37,8 @@ object Scala3CompilerApi: | |||
| case v: ValDef if v.mods.is(CaseAccessor) => v | |||
| } | |||
|
|
|||
| def className(clazz: Clazz): String = clazz.clazz.name.toString | |||
| def className(clazz: Clazz): String = | |||
| clazz.clazz.originalName.toString | |||
There was a problem hiding this comment.
originalName lets us avoid the $ in case objects.
mrobakowski
approved these changes
Jul 12, 2021
| } | ||
| // note: also returns vals because why not | ||
| def methodNames(clazz: Clazz): List[String] = | ||
| clazz.t.body.collect { case d: (DefDef | ValDef) => |
There was a problem hiding this comment.
You can do that in Scala 3??? pog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
override val toStringget a duplicate definition #56 by including vals in our search for existingtoStrings$and()from the toStrings of case objects in Scala 3 (I think it wasn't an issue in Scala 2 because we never touch case objects in these versions)