Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle renaming of gene names in alleles in --change-gene-id #2830

Merged
merged 2 commits into from
May 2, 2024

Conversation

jseager7
Copy link
Collaborator

@jseager7 jseager7 commented May 2, 2024

I've added a flag --no-rename to canto_admin.pl that, when set with --change-gene-id, skips the renaming of gene names in allele names. This was needed because PHI-base wanted to keep using the gene name that was specified in the publication for our annotations.

The --no-rename flag defaults to 0 instead of undef. If the --no-rename flag is set with any other flag, the script warns and exits:

Error: --no-rename is only allowed with --change-gene-id

This required adding an argument $no_rename to change_gene_id in TrackUtil.pm that skips the allele renaming when set. I didn't bother to set a default value for this argument because change_gene_id is currently only used in one place.

I've tested this with PHI-Canto where it works fine both with and without the new flag. I haven't tested any other modes.

@jseager7 jseager7 self-assigned this May 2, 2024
@kimrutherford
Copy link
Member

Thanks James. Both of those patches look great.

@kimrutherford kimrutherford merged commit c01491b into pombase:master May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants