Merge branch 'stood-feature-add-test-status-code'

pomm-project · Jun 20, 2018 · 6cff486 · 6cff486
2 parents 4d1c589 + b60c752
commit 6cff486
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 1 deletion.
diff --git a/tests/src/AppBundle/Controller/IndexController.php b/tests/src/AppBundle/Controller/IndexController.php
@@ -149,7 +149,7 @@ public function propertyListAction()
         );
     }
 
-    public function propertyTypeAction(string $property)
+    public function propertyTypeAction($property)
     {
         $info = $this->property->getTypes('AppBundle\Model\MyDb1\PublicSchema\Config', $property);
 

diff --git a/tests/tests/Features/autowire.feature b/tests/tests/Features/autowire.feature
@@ -3,4 +3,5 @@ Feature: Autowire
 
   Scenario:
     When I am on "/app_dev.php/get_autowire/test"
+    Then the response status code should be 200
     Then I should see "test => value"
diff --git a/tests/tests/Features/param-converter.feature b/tests/tests/Features/param-converter.feature
@@ -2,20 +2,25 @@ Feature: Entity Param Converter
 
     Scenario:
         When I am on "/app_dev.php/get/test"
+        Then the response status code should be 200
         Then I should see "test => value"
 
     Scenario:
         When I am on "/app_dev.php/get"
+        Then the response status code should be 200
         Then I should see "config => null"
 
     Scenario:
         When I am on "/app_dev.php/get_session_default/test"
+        Then the response status code should be 200
         Then I should see "test => value"
 
     Scenario:
         When I am on "/app_dev.php/get_session_1/test"
+        Then the response status code should be 200
         Then I should see "test => value"
 
     Scenario:
         When I am on "/app_dev.php/get_session_2/test"
+        Then the response status code should be 200
         Then I should see "test => value_db2"
diff --git a/tests/tests/Features/property-info.feature b/tests/tests/Features/property-info.feature
@@ -2,8 +2,10 @@ Feature: Entity Param Converter
 
     Scenario: property list
         When I am on "/app_dev.php/property"
+        Then the response status code should be 200
         Then I should see "name/value"
 
     Scenario: property type
         When I am on "/app_dev.php/property/name"
+        Then the response status code should be 200
         Then I should see "string"
diff --git a/tests/tests/Features/serializer.feature b/tests/tests/Features/serializer.feature
@@ -2,6 +2,7 @@ Feature: Entity Serialization
 
     Scenario:
         When I am on "/app_dev.php/serialize"
+        Then the response status code should be 200
         Then the response should be in JSON
         And the JSON should be equal to:
         """
@@ -17,6 +18,7 @@ Feature: Entity Serialization
 
     Scenario:
         When I am on "/app_dev.php/deserialize"
+        Then the response status code should be 200
         Then I should see "AppBundle\Model\MyDb1\PublicSchema\Config"
         And I should see "'name' => 'test'"
         And I should see "'value' => 'ok'"
diff --git a/tests/tests/Features/service-model.feature b/tests/tests/Features/service-model.feature
@@ -2,8 +2,10 @@ Feature: Model as service
 
     Scenario:
         When I am on "/app_dev.php/serviceModel"
+        Then the response status code should be 200
         Then I should see "Created model as service. Sum:2"
 
     Scenario:
         When I am on "/app_dev.php/serviceContainer"
+        Then the response status code should be 200
         Then I should see "Model from container as service. Sum:2"
diff --git a/tests/tests/Features/toolbar.feature b/tests/tests/Features/toolbar.feature
@@ -2,12 +2,15 @@ Feature: Web debug toolbar
 
     Scenario:
         When I am on homepage
+        Then the response status code should be 200
         Then I should see the debug toolbar
 
     Scenario: Query
         When I am on the pomm profiler
+        Then the response status code should be 200
         Then I should see "Queries"
 
     Scenario: Timeline
         When I am on the timeline
+        Then the response status code should be 200
         Then I should see "pomm"