Skip to content

Latest commit

 

History

History
76 lines (57 loc) · 2.77 KB

cran-comments.md

File metadata and controls

76 lines (57 loc) · 2.77 KB
Raw

Version 0.3.4

fix deprecated error messages.

Version 0.3.3

small update

Version 0.3.2

Following Cran e-mail (from Prof Brian Ripley), remove strip-debug in Makevars file. Now the size of the package is > 10Mb and it generates a Warning regarding its size.

Please remove unconditional stripping ASAP and before Apr 24 to safely
retain the package on CRAN.

Version 0.3.1

Following cran response, tests have been shortened by using multithreading during model training (before use only 1 thread)

Version 0.3.0

  • big C++ code update
  • fix littl bug in catching C++ exception as reported by Cran server

I had to re-upload the package as bug in a corner case appeared. I am sorry for that.

Version 0.2.6

  • use -pthread flag for better Cran compliancy

Version 0.2.3 - 08.10.17 - answer

Cran: Thanks, we see that the Date field is over a month old. Is this the right version?

Answer: This is the right version but I have made an error in the date.

Version 0.2.3 - 08.10.17

  • fix Cran notes
  • fix a bug introduced in the last update

Version 0.2.2 - 06.10.17

  • add a dependency to fix some very specific crash due to Rcout called from different threads.
  • fix compilation on Mac OS with RcppThread

Version 0.2.1 - 18.09.17

  • Fix compilation crash on Mac OS
  • remove notes on R devel

Comments from Swetlana Herbrandt - 15.09.17 - 4:45PM (French time)

  • please omit the redundant 'R' in your title -> the R is now removed from the title field.
  • please write package names and software names in Title and Description in single quotes (e.g. 'FastText'). -> quotes have been applied on any software name.
  • please add an URL for 'FastText' in the form http:... or https:... with angle brackets for auto-linking and no space after 'http:' and 'https:' -> the link has been added at the end of the decsription text.
  • we see code lines such as Copyright (c) 2016-present, Facebook, Inc. All rights reserved. Please add all authors and copyright holders in the Authors@R field with the appropriate roles. -> a new person Facebook, Inc. has been added, with the role cph

Note to Cran

The introduction of quotes (see above) has raised a new note: "The Description field should start with a capital letter." This is wanted.

Test environments

  • Local ubuntu 17.04 + R version 3.4.1
  • R-Hub Cran check (Linux + Windows)
  • App veyor, Windows
  • Travis-CI, Linux

R CMD check results

  • Local: no warning, no note
  • Travis-CI: no warning, no note
  • R-Hub Cran check:
    • 1 note: "Possibly mis-spelled words in DESCRIPTION" -> there is no error
  • App Veyor:
    • 1 note: "Found no calls to: 'R_registerRoutines', 'R_useDynamicSymbols'" -> App Veyor tool chain is known to not be up to date, it may be the cause of this note. The note can't be reproduced on R-Hub Windows check.