Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks #354

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

francesco-gaglione
Copy link
Contributor

Pr linked with #353

Working on this while waiting for the design discussion

@francesco-gaglione
Copy link
Contributor Author

The implementation in this pull request is a working implementation. I know that this functionality needs to be revised by the graphics team. In the meantime, I have implemented this functionality by modifying the UI/UX as little as possible.
Initially I wanted to put icons in the list view as in the gnome file, but this was not possible due to a bug in the row button. So I moved the addition/removal of the bookmark to the context menu (this way the UI is not changed).
The current implementation will probably not be the final one, it can be extended further (especially in terms of the UI) but it is already working and may be useful for alpha 2.

@francesco-gaglione francesco-gaglione marked this pull request as ready for review August 15, 2024 14:47
@jackpot51 jackpot51 self-requested a review August 15, 2024 15:03
@francesco-gaglione francesco-gaglione marked this pull request as draft August 25, 2024 14:12
@francesco-gaglione francesco-gaglione marked this pull request as ready for review September 5, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant