-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run executables #521
Run executables #521
Conversation
Hey, Can you also add support for binaries? At present it opens in default browser and ask to save the file. |
@francesco-gaglione if you want, I can take over to add the dialog for enabling the executable permission, and for also triggering when the file is an ELF file rather than just when it has an AppImage extension. |
@jackpot51 I was working on it, but... I was trying to create a general "allow permission change" dialog. But it was not possible because I don't have a callback in the message. So I ended up by create a specific dialog for this scope, but again this mean to move the run logic into the dialog... and idk, probabliy this is not the best solution. Do you think we have a better solution or it is accetable? |
Would it better to rename
|
I was trying to do not ask for permission if it already have it. So in tratti case the nome is perfect but execution should be ouside the dialog. I will fix these for now, but later I want try to check run permission, ask if needed and than execute it (any executable). I didn't jad much time, if no one will finish before me Ill try asap |
Closes #23 #525