Remove the dependency on ouroboros #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces compilation time by removing a dependency on syn and other dependencies of ouroboros_macros. In addition it saves a lot of unused codegened methods. On my laptop (2 core + HT) this reduces compilation time by ~20%. On a many core system this doesn't help much though as the critical path path consists of both ttf-parser -> rustybuzz and swash. Further gains will likely need to be made by reducing compilation time for these crates. Benchmark 1: cargo build Time (mean ± σ): 25.150 s ± 0.167 s [User: 84.414 s, System: 7.335 s] Range (min … max): 24.909 s … 25.444 s 10 runs Benchmark 1: cargo build Time (mean ± σ): 19.819 s ± 0.226 s [User: 67.754 s, System: 5.592 s] Range (min … max): 19.492 s … 20.140 s 10 runs The code is based on an expansion of the ouroboros macro, cleaned up to remove all unused methods and inline most functions that are only called once.
|
axelf4/unicode-linebreak#8 by @NobodyXu also helps with compilation time. |
|
Looks like there may be an easy win for swash: dfrg/swash#37 (comment) |
jackpot51
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces compilation time by removing a dependency on syn and other dependencies of ouroboros_macros. In addition it saves a lot of unused codegened methods.
On my laptop (2 core + HT) this reduces compilation time by ~20%. On a many core system this doesn't help much though as the critical path path consists of both ttf-parser -> rustybuzz and swash. Further gains will likely need to be made by reducing compilation time for these crates.
The code is based on an expansion of the ouroboros macro, cleaned up to remove all unused methods and inline most functions that are only called once.