-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme update #138
Theme update #138
Conversation
Oh I guess I need to wait for a new release of the palette crate with the oklch and oklab fix |
…en custom and system theme settings
…overlays than others when they are hovered or pressed
So the goal of using a Are we sure we'd never try to access this from a different thread, even if Iced is using a multi-threaded async executor? If that happened, it would silently use a different instance of the variable local to that thread, which could be confusing. This would also be a problem if multiple instance of |
There isn't a need to access the theme from a different thread because the view methods are always run from the same event loop on the main thread. Elements would otherwise require a static lifetime along with I think we'd support concurrent execution of multiple application instances from the same thread, too. Similar to GTK, we could make a socket that listens for new application requests, and then register additional instances in our iced runtime, with events that are accompanied by an application instance ID. |
Yeah, I guess |
If we find a better solution to using a thread local, perhaps with changes to how theming works in upstream Iced, we can change that. But it should be fine for now. This otherwise looks good. |
This is an implementation of the new design. It also removes some of the old code which had similar-ish functionality that we don't need anymore.