Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22.04 Deferred Improvements #279

Open
3 of 9 tasks
jacobgkau opened this issue Apr 20, 2022 · 4 comments
Open
3 of 9 tasks

22.04 Deferred Improvements #279

jacobgkau opened this issue Apr 20, 2022 · 4 comments

Comments

@jacobgkau
Copy link
Member

jacobgkau commented Apr 20, 2022

This is a list of items that were not addressed in pop-os/system-updater#1 / #225 / pop-os/shop#342, but could be improved. These can be broken out into separate issues if desired, I'm just getting them down first.

  • system-updater spinboxes:
    • Make up/down keys increment spinboxes by 1 instead of 3
    • Make hours roll over when incrementing minutes past 0 or 59
    • Prevent three-digit numbers from being entered and rounding to 12
    • Allow 1 or 0 digits in the text box transiently to allow backspacing/typing more normally
  • Consider making system-updater run apt autoremove to keep clutter from building up on the system
  • Make the Pop!_Shop not immediately recheck for updates after clicking a notification from system-updater (system-updater just checked for updates, so the Pop!_Shop should be able to just use the cache)
  • Fix the Pop!_Shop launching behavior so it always opens to the Installed tab when clicking an update notification (it currently opens to the Home tab if the Pop!_Shop process was already running in the background before clicking the notification)
  • Correct behavior of CLI recovery partition progress reporting to reflect that it's finished downloading before moving on
@xploz1on
Copy link

  • Consider making system-updater run apt autoremove to keep clutter from building up on the system
  • Make the Pop!_Shop not immediately recheck for updates after clicking a notification from system-updater (system-updater just checked for updates, so the Pop!_Shop should be able to just use the cache)
  • Fix the Pop!_Shop launching behavior so it always opens to the Installed tab when clicking an update notification (it currently opens to the Home tab if the Pop!_Shop process was already running in the background before clicking the notification)

Pretty much sums up the "Pop!_Shop freezes" report everyone makes. Your suggestions are perfect.

@jacobgkau
Copy link
Member Author

Pretty much sums up the "Pop!_Shop freezes" report everyone makes. Your suggestions are perfect.

These have to do with new pop-upgrade integration and are not related to existing Pop!_Shop performance complaints.

@xploz1on
Copy link

xploz1on commented Apr 20, 2022

  • Make the Pop!_Shop not immediately recheck for updates after clicking a notification from system-updater (system-updater just checked for updates, so the Pop!_Shop should be able to just use the cache).

At least this one happens all the time for almost everyone. This adds the frozen stage while checking for updates. (Doesn't happen for everyone; i guess depends on internet speed?)

@jacobgkau
Copy link
Member Author

jacobgkau commented Apr 20, 2022

At least this one happens all the time for almost everyone. This adds the frozen stage while checking for updates.

Yes, it was expected behavior before (the update checks, not the freezing), and that functionality being moved into a different component will have the side effect of removing it from the Pop!_Shop.

I did specify "after clicking a notification from system-updater," so I would still expect the Pop!_Shop to check for updates if you start it by clicking on it in the dock/application menu/etc. It might not be entirely necessary for that to be the case, but removing the Pop!_Shop's ability to refresh the package lists would be a separate discussion. That could lead to issues trying to install a package after it's been updated and before system-updater's next update check (which could be as long as a month away, depending on user configuration.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants