Refactored creation of expand and collapse actions

Issue: #4311 Co-authored-by: Alexander Ott <webmaster@nirus-online.de> Co-authored-by: Andreas Buchen <andreas.buchen@gmail.com>
portfolio-performance · Nov 9, 2024 · c61d5c0 · c61d5c0
1 parent e143c41
commit c61d5c0
Showing 1 changed file with 4 additions and 32 deletions.
diff --git a/name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/views/PerformanceView.java b/name.abuchen.portfolio.ui/src/name/abuchen/portfolio/ui/views/PerformanceView.java
@@ -8,7 +8,6 @@
 import jakarta.inject.Inject;
 
 import org.eclipse.e4.ui.services.IStylingEngine;
-import org.eclipse.jface.action.Action;
 import org.eclipse.jface.action.IMenuListener;
 import org.eclipse.jface.action.IMenuManager;
 import org.eclipse.jface.action.Separator;
@@ -389,29 +388,17 @@ private void addTreeActionsContextMenu(IMenuManager manager, Object obj)
         if (obj == null)
             return;
 
-        manager.add(new Action(Messages.LabelExpand)
+        manager.add(new SimpleAction(Messages.LabelExpand, a -> calculation.setExpandedState(obj, true))
         {
-            @Override
-            public void run()
-            {
-                calculation.setExpandedState(obj, true);
-            }
-
             @Override
             public boolean isEnabled()
             {
                 return calculation.isExpandable(obj) && !calculation.getExpandedState(obj);
             }
         });
 
-        manager.add(new Action(Messages.LabelCollapse)
+        manager.add(new SimpleAction(Messages.LabelCollapse, a -> calculation.setExpandedState(obj, false))
         {
-            @Override
-            public void run()
-            {
-                calculation.setExpandedState(obj, false);
-            }
-
             @Override
             public boolean isEnabled()
             {
@@ -421,23 +408,8 @@ public boolean isEnabled()
 
         manager.add(new Separator());
 
-        manager.add(new Action(Messages.LabelExpandAll)
-        {
-            @Override
-            public void run()
-            {
-                calculation.expandAll();
-            }
-        });
-
-        manager.add(new Action(Messages.LabelCollapseAll)
-        {
-            @Override
-            public void run()
-            {
-                calculation.collapseAll();
-            }
-        });
+        manager.add(new SimpleAction(Messages.LabelExpandAll, a -> calculation.expandAll()));
+        manager.add(new SimpleAction(Messages.LabelCollapseAll, a -> calculation.collapseAll()));
     }
 
     private TableViewer createTransactionViewer(CTabFolder folder, String title)