Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt swtchart piechart slice color to dark/light theme #4300

Merged

Conversation

mierin12
Copy link
Contributor

previously slices were white in any theme

Hello, this is a proposition to adapt the color of the slice of swtpiechart to the black/white them. The HTML pie charts do adapt their slice color already.

Before :
Capture d’écran 2024-10-22 200614
Capture d’écran 2024-10-22 200739
Capture d’écran 2024-10-22 200759

After :
Capture d’écran 2024-10-22 200703
Capture d’écran 2024-10-22 200717
Capture d’écran 2024-10-22 200819

also applicable to the pie chart widgets.

HTML pie chart : already adapting the slice color
Capture d’écran 2024-10-22 200638

One little downside : I think it is a bit more noticeable when color sticks out of the pie, "toward the inside". Well, in white it was the opposite : noticeable "toward the outside", while no longer as much noticeable in black.

In white theme, I do not notice any change in behavior.

previously slices were white in any theme
@mierin12 mierin12 changed the title adapt pie chart slice color to dark/light them adapt pie chart slice color to dark/light theme Oct 22, 2024
@mierin12 mierin12 changed the title adapt pie chart slice color to dark/light theme adapt swtchart piechart slice color to dark/light theme Oct 23, 2024
@buchen buchen merged commit a8845f3 into portfolio-performance:master Oct 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants