Skip to content

Commit

Permalink
E2E test: stop building positron to run release test (#5896)
Browse files Browse the repository at this point in the history
Stop building Positron to run tests against the last release

### QA Notes

All release tests should pass.
  • Loading branch information
testlabauto authored Jan 8, 2025
1 parent be85387 commit 0823a33
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 3 deletions.
19 changes: 17 additions & 2 deletions .github/workflows/test-e2e-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,24 @@ jobs:
libgtk-3-0 libgbm1 libnss3 libnspr4 libasound2 libkrb5-dev libcairo-dev \
libsdl-pango-dev libjpeg-dev libgif-dev pandoc
- name: Compile tests
- name: Setup test dependencies and compile tests
run: |
npm install
# Must remove root package.json and provide simple stub to use root dir for test run but not build
rm package.json
echo '{"scripts":{"compile":"npx tsc"}}' > package.json
# Install TypeScript locally
npm install typescript
# Install required dependencies - must keep in sync with root package.json
npm install @playwright/test@^1.49.0
npx playwright install
npx playwright install-deps
npm install @currents/playwright@^1.8.0
npm install @midleman/github-actions-reporter@^1.9.5
npm install @vscode/v8-heap-parser@^0.1.0
npm install fs-extra
npm --prefix test/e2e install
npm --prefix test/e2e run compile
Expand Down
4 changes: 3 additions & 1 deletion test/e2e/infra/playwrightDriver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,9 @@ export class PlaywrightDriver {
}

private async evaluateWithDriver<T>(pageFunction: PageFunction<IWindowDriver[], T>) {
return this.page.evaluate(pageFunction, [await this.getDriverHandle()]);
const driverHandle = await this.getDriverHandle();
const driver = driverHandle as unknown as IWindowDriver; // Explicit cast
return this.page.evaluate(pageFunction, [driver]);
}

wait(ms: number): Promise<void> {
Expand Down

0 comments on commit 0823a33

Please sign in to comment.