Skip to content

Commit

Permalink
disable jupyter interactive window setting (#2854)
Browse files Browse the repository at this point in the history
  • Loading branch information
seeM authored Apr 23, 2024
1 parent 1abacb3 commit 12d925f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 2 additions & 0 deletions src/vs/workbench/api/common/configurationExtensionPoint.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { MarkdownString } from 'vs/base/common/htmlContent';

// --- Start Positron ---
// Ignore properties contributed by vscode-jupyter related in favor of Positron code cells and console.
// These are disabled in the settings UI. To override their actual values see extHostConfiguration.ts.
// TODO(seem): We can remove this if we eventually decide to unbundle vscode-jupyter.
const IGNORED_JUPYTER_CONFIGURATION_PROPERTIES = new Set([
'jupyter.decorateCells',
Expand All @@ -32,6 +33,7 @@ const IGNORED_JUPYTER_CONFIGURATION_PROPERTIES = new Set([
'jupyter.interactiveWindow.codeLens.commands',
'jupyter.interactiveWindow.codeLens.enable',
'jupyter.interactiveWindow.codeLens.enableGotoCell',
// The typo in the following property is intentional, don't fix it.
'jupyter.interactiveWindow.codeLes.debugCommands',
'jupyter.interactiveWindow.creationMode',
'jupyter.interactiveWindow.textEditor.autoAddNewCell',
Expand Down
5 changes: 3 additions & 2 deletions src/vs/workbench/api/common/extHostConfiguration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -185,13 +185,14 @@ export class ExtHostConfigProvider {
},
get: <T>(key: string, defaultValue?: T) => {
// --- Start Positron ---
// Disable vscode-jupyter's cell decorations and code lenses, preferring
// the positron-code-cell extension instead.
// Disable vscode-jupyter's cell decorations, code lenses, and interactive window
// entrpoints, preferring Positron alternatives instead.
// TODO(seem): We can remove this if we eventually decide to unbundle vscode-jupyter.
if (section === 'jupyter') {
switch (key) {
case 'interactiveWindow.cellMarker.decorateCells':
case 'interactiveWindow.codeLens.enable':
case 'interactiveWindow.textEditor.executeSelection':
// Legacy versions of above settings.
case 'decorateCells':
case 'enableCellCodeLens':
Expand Down

0 comments on commit 12d925f

Please sign in to comment.