Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a central place to disclose use and comply with the MIT license's requirement for attribution #1809

Closed
jennybc opened this issue Nov 9, 2023 · 4 comments
Closed

Create a central place to disclose use and comply with the MIT license's requirement for attribution #1809

jennybc opened this issue Nov 9, 2023 · 4 comments
Assignees
@petetronic
Labels
area: core Issues related to Core category.
Milestone
Public Beta 2024 Q2

Comments

@jennybc
Copy link
Member

jennybc commented Nov 9, 2023

In #1763, the positron-r extension gained testing functionality that was originally adapted from the MIT licensed extension https://github.com/meakbiyik/vscode-r-test-adapter/.

@jmcphers suggested during code review that we open this issue to track this and any other/future 3rd party components under the MIT license:

... we need a central place to disclose use and comply with the MIT license's requirement for attribution... For many orgs it's a big deal to have a list of all third party components/code in use, and for this reason RStudio provides an exhaustive list in NOTICE (also available from the Help menu). Positron will want something similar.
@jennybc jennybc mentioned this issue Nov 9, 2023
Merged
@jennybc jennybc added this to the Public Beta 2024 Q2 milestone Feb 23, 2024
@wesm wesm added the area: core Issues related to Core category. label Feb 29, 2024
@juliasilge juliasilge mentioned this issue Apr 18, 2024
Closed
1 task
@petetronic
Copy link
Collaborator

What about https://github.com/posit-dev/positron/blob/main/ThirdPartyNotices.txt?

@juliasilge
Copy link
Contributor

What is the right way to handle third party license info for Positron itself vs. built-in extensions?

Note these examples as of today:

@petetronic petetronic self-assigned this May 6, 2024
@jmcphers jmcphers mentioned this issue Jun 4, 2024
Closed
@petetronic
Copy link
Collaborator

Third party licenses, and relevant notices, should be tracked in the top level ThirdPartyNotices.txt file.

The following items need to be addressed:

  • Files we added to some of our extensions in extensions/positron-r/LICENSE, extensions/positron-rstudio-keymap/LICENSE, extensions/positron-viewer/LICENSE, will be removed. These are built-in extensions under the license of the positron repository.
  • extensions/positron-r/resources/testing/vscodereporter/LICENSE, will be added to ThirdPartyNotices.txt
  • extensions/positron-python/LICENSE and extensions/positron-python/pythonExtensionAPI/LICENSE.md were inherited from upstream, but will be added to ThirdPartyNotices.txt
  • build/monaco/LICENSE will be added to the ThirdPartyNotices.txt file

petetronic added a commit that referenced this issue Jun 5, 2024
@petetronic
Clean-up third-party licenses and positron extensions
5a0a78f 
Remove unnecessary LICENSE files that had been added to some positron extensions. These are
built-in and covered by Positron's license and copyright.

Added some missing third-party notice information to the top-level ThirdPartyNotices.txt

Addresses a question from #1809
@petetronic petetronic mentioned this issue Jun 5, 2024
Merged
petetronic added a commit that referenced this issue Jun 6, 2024
@petetronic
Clean-up some third-party licenses and Positron extensions (#3412)
231c72c 
* Clean-up third-party licenses and positron extensions

Remove unnecessary LICENSE files that had been added to some positron extensions. These are
built-in and covered by Positron's license and copyright.

Added some missing third-party notice information to the top-level ThirdPartyNotices.txt

Addresses a question from #1809

* Add vscode-r-test-adapter license to ThirdPartyLicenses.txt
nstrayer pushed a commit that referenced this issue Jun 6, 2024
@petetronic @nstrayer
Clean-up some third-party licenses and Positron extensions (#3412)
d2cbae1 
* Clean-up third-party licenses and positron extensions

Remove unnecessary LICENSE files that had been added to some positron extensions. These are
built-in and covered by Positron's license and copyright.

Added some missing third-party notice information to the top-level ThirdPartyNotices.txt

Addresses a question from #1809

* Add vscode-r-test-adapter license to ThirdPartyLicenses.txt
@juliasilge
Copy link
Contributor

With Positron 2024.06.0 (Universal) build 35 installed, I see the expected updated info in ThirdPartyNotices.txt:

Image

I see that wc -l ThirdPartyNotices.txt is 3402. ✅

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petetronic petetronic

Labels
area: core Issues related to Core category.
Projects
None yet
Milestone
Public Beta 2024 Q2
Development

No branches or pull requests
4 participants
@wesm @jennybc @petetronic @juliasilge