Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter interactive window still shows up in settings #2144

Closed
jgutman opened this issue Jan 26, 2024 · 3 comments
Closed

Jupyter interactive window still shows up in settings #2144

jgutman opened this issue Jan 26, 2024 · 3 comments
Assignees

Comments

@jgutman
Copy link
Contributor

jgutman commented Jan 26, 2024

We previously removed almost all references to the jupyter interactive window sessions from positron. However, there are still many references to jupyter interactive window sessions in settings

Given that these come from the Jupyter adapter and we don't fork that extension, I am not sure whether it's possible to suppress these settings like we did with the UI elements, but it could be worth considering.

In particular, I'm concerned about the shift + enter keyboard shortcut setting. If the user enables that setting, and then hits shift + enter, it will open a Jupyter interactive window session

image
@seeM seeM self-assigned this Feb 7, 2024
@jgutman jgutman added this to the Release Candidate milestone Feb 26, 2024
@seeM seeM removed their assignment Apr 2, 2024
@seeM seeM self-assigned this Apr 18, 2024
@seeM
Copy link
Contributor

seeM commented Apr 19, 2024

#2788 only stopped the configuration properties from showing up in the settings, but if you add "jupyter.interactiveWindow.textEditor.executeSelection": true to your settings.json, and hit Shift+Enter in a Python file, you can still open the interactive window. Will make a follow-up PR.

@seeM
Copy link
Contributor

seeM commented Apr 23, 2024

To verify:

  1. Check that no irrelevant Jupyter settings show in the settings UI.
  2. Manually add the setting "jupyter.interactiveWindow.textEditor.executeSelection": true to your settings.json file, open a Python file and press Shift+Enter. It should not open an "Interactive Window" tab.

@juliasilge
Copy link
Contributor

In Positron 2024.04.0 build 1579, I do not see any jupyter.interactiveWindow settings in the UI:

Image

If I try to manually add it to a settings.json, it is grayed out and looks like it doesn't do anything:

Image

If I then use Shift+Enter in a Python file, no interactive window opens.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants