Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle ms-python.debugpy in build #2595

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Bundle ms-python.debugpy in build #2595

merged 6 commits into from
Apr 18, 2024

Conversation

isabelizimm
Copy link
Contributor

Intent

Describe briefly what problem this pull request resolves, or what new feature it introduces. Include screenshots of any new or altered UI. Link to any GitHub issues that are related.

addresses #2540

Approach

Describe the approach taken and the tradeoffs involved if non-obvious; add an overview of the solution if it's complicated.

used values from ~/.vscode/extensions/extensions.json, extension name ms-python.debugpy

QA Notes

Add additional information for QA on how to validate the change, paying special attention to the level of risk, adjacent areas that could be affected by the change, and any important contextual information not present in the linked issues.

If you create a local build, you should be able to see debugpy in extensions.

@isabelizimm
Copy link
Contributor Author

isabelizimm commented Apr 1, 2024

I see the link https://open-vsx.org/api/ms-python/debugpy/darwin-arm64/2024.2.0/file/ms-python.debugpy-2024.2.0@darwin-arm64.vsix works fine, but the URL we use on build gives a 404 👀

@isabelizimm
Copy link
Contributor Author

isabelizimm commented Apr 17, 2024

Link format for platform specific: https://open-vsx.org/api/{PUBLISHER}/{EXT_NAME}/{PLATFORM}/{VERSION}/file/{EXT_ID}-{VERSION}@{PLATFORM}.vsix

^ this will be different if it is a universal download

OR

curl -X 'GET' \
  'https://open-vsx.org/api/ms-python/debugpy' \
  -H 'accept: application/json'

in {'files': 'download': URL} will work for all extensions, platform specific or universal.


Windows: https://open-vsx.org/api/ms-python/debugpy/win32-x64/2024.4.0/file/ms-python.debugpy-2024.4.0@win32-x64.vsix
Linux: https://open-vsx.org/api/ms-python/debugpy/linux-x64/2024.4.0/file/ms-python.debugpy-2024.4.0@linux-x64.vsix
macOS Silicon: https://open-vsx.org/api/ms-python/debugpy/darwin-arm64/2024.4.0/file/ms-python.debugpy-2024.4.0@darwin-arm64.vsix


there's also ovsx for a CLI package.

@isabelizimm
Copy link
Contributor Author

Is it normal to have to add the js? I have never needed to do that before AFAIK?

Do note: this will download the extension for whatever platform the building computer is.

@isabelizimm isabelizimm requested a review from petetronic April 18, 2024 13:21
product.json Outdated
@@ -199,17 +215,10 @@
"nlsBaseUrl": "",
"publisherUrl": ""
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but this JSON reformatting will make future upstream merges potentially noisy, any chance we could avoid that?

@petetronic
Copy link
Collaborator

Is it normal to have to add the js? I have never needed to do that before AFAIK?

Do note: this will download the extension for whatever platform the building computer is.

It does seem to be required for the build/lib area, see upstream https://github.com/microsoft/vscode/blob/main/build/lib/extensions.js

@isabelizimm isabelizimm requested a review from petetronic April 18, 2024 18:05
Copy link
Collaborator

@petetronic petetronic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was able to build locally, see debugpy extension was installed, and debug a .py file (via a custom terminal, as the extension currently works).

@isabelizimm isabelizimm merged commit 25dfb00 into main Apr 18, 2024
1 check passed
@isabelizimm isabelizimm deleted the fix/bundle-debugpy branch April 18, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants