-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle ms-python.debugpy
in build
#2595
Conversation
I see the link https://open-vsx.org/api/ms-python/debugpy/darwin-arm64/2024.2.0/file/ms-python.debugpy-2024.2.0@darwin-arm64.vsix works fine, but the URL we use on build gives a 404 👀 |
Link format for platform specific: https://open-vsx.org/api/{PUBLISHER}/{EXT_NAME}/{PLATFORM}/{VERSION}/file/{EXT_ID}-{VERSION}@{PLATFORM}.vsix ^ this will be different if it is a universal download OR
in Windows: https://open-vsx.org/api/ms-python/debugpy/win32-x64/2024.4.0/file/ms-python.debugpy-2024.4.0@win32-x64.vsix there's also ovsx for a CLI package. |
Is it normal to have to add the js? I have never needed to do that before AFAIK? Do note: this will download the extension for whatever platform the building computer is. |
product.json
Outdated
@@ -199,17 +215,10 @@ | |||
"nlsBaseUrl": "", | |||
"publisherUrl": "" | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, but this JSON reformatting will make future upstream merges potentially noisy, any chance we could avoid that?
It does seem to be required for the build/lib area, see upstream https://github.com/microsoft/vscode/blob/main/build/lib/extensions.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I was able to build locally, see debugpy extension was installed, and debug a .py file (via a custom terminal, as the extension currently works).
Intent
addresses #2540
Approach
used values from
~/.vscode/extensions/extensions.json
, extension namems-python.debugpy
QA Notes
If you create a local build, you should be able to see debugpy in extensions.