UI/drop down list box work #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharon-wang
approved these changes
Apr 9, 2024
src/vs/workbench/browser/positronComponents/dropDownListBox/dropDownListBox.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This PR adds the ability to display a custom component for drop down list box items. It also updates new project wizard so that it draws a custom drop down list box item called
PythonInterpreterEntryfor selecting the Python interpreter.Approach
DropDownListBoxandDropDownListBoxEntryare now generic types so that it is possible to supply custom identifiers and values for drop down list box entries. Additionally,DropDownListBoxnow has a factory function calledcreateItemthat is called to display a custom component for drop down list box items.QA Notes
None.