Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Variables -> Debug Variables #2722

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Conversation

DavisVaughan
Copy link
Contributor

Related to posit-dev/ark#307

I'm not sure we need to do this, since you only ever see this Variables view when you are in the Run and Debug section of the Activity Bar which feels pretty clear that those are different variables than the ones in the session Variables pane.

On the flip side, this is now consistent with the fact that we have a session Console and also the Debug Console, which is kind of nice.

If we decide we don't like this for some reason in the future, it's at least easy to back out

Screenshot 2024-04-10 at 12 52 38 PM

The point of this is to try and avoid confusion with the session Variables pane. The naming here tries to be consistent with how we have a session Console and a Debug Console.
Copy link
Collaborator

@petetronic petetronic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried your branch locally and saw the debug variables pane with the correct new name "DEBUG VARIABLES". Was there no nls file with this that needed updating too?

@DavisVaughan
Copy link
Contributor Author

I'm not 100% sure but I think nls.localize2() marks the strings in such a way that it can auto generate the nls file at build time

@DavisVaughan DavisVaughan merged commit 2f87f10 into main Apr 11, 2024
1 check passed
@DavisVaughan DavisVaughan deleted the feature/debug-variables branch April 11, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants