Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/data explorer filtering #2728

Merged
merged 3 commits into from
Apr 10, 2024
Merged

UI/data explorer filtering #2728

merged 3 commits into from
Apr 10, 2024

Conversation

softwarenerd
Copy link
Contributor

Intent

This PR enables row filtering in the Data Explorer.

Approach

QA Notes

Basic row filtering is enabled in the Data Explorer.

@softwarenerd softwarenerd requested a review from wesm April 10, 2024 19:07
Copy link
Contributor

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Tested this out locally and working correctly.

A few follow up notes:

I'll create some issues for these

@wesm wesm merged commit c5a007f into main Apr 10, 2024
24 checks passed
@wesm wesm deleted the ui/data-explorer-filtering branch April 10, 2024 20:36
@wesm
Copy link
Contributor

wesm commented Apr 10, 2024

I also noticed a fade-in effect with dropdown boxes that adds maybe 100-200ms of waiting, can this be configured to be snappier? unrelated to these changes, see #2733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants