-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactions for selecting project type in project wizard #2746
Interactions for selecting project type in project wizard #2746
Conversation
- add ProjectType and ProjectTypeGroup (based on RadioButton and RadioButtonGroup) - store the user's project type selection in the project state
src/vs/workbench/browser/positronNewProjectWizard/components/logos/jupyter/LICENSE.txt
Outdated
Show resolved
Hide resolved
Overall, great to see the icons and this really coming together! After this lands, we may get some additional requests from Paul as he gets a chance to interact with it, but IMHO, here are some of my thoughts: For the Light and Dark regular (non-HC) themes, could we add a subtle hover highlight to add more feedback to the user this is an interactive button? There are a few examples of this in other action bars like our Plots and Variables panes. In the regular Light theme, button background grey seems a little drab / intense given how large the clickable area is. Would a softer / brighter treatment be like the top action bar buttons, I think they have a subtle grey border and very light background? For the HC themes, I think buttons always have a thin border outline? There should be examples in our various action bars too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The outlines in HC themes and hover highlighting would be great to have! |
- make border colour the same as the background colour for regular light and dark mode - make onhover and onselected similarly styled
Thanks for the suggestions! I've added a new video near the top of the PR description to show the styling changes, including hover highlighting. There's still an issue with focus which I'll address later: extra_outline_from_focus.mp4There is an extra outline around the mouse-clicked button. The outline should only show when using keyboard navigation. The extra outline doesn't occur when navigating back to the first step and clicking on the buttons. This has to do with manually |
I'll merge this for now and address additional styling feedback in a separate PR |
Intent
Before
This PR
This PR updates the first step of the New Project Wizard to have selectable project types with corresponding logos. The selected project type is saved to the project config, which is part of the project wizard state.
update_project_type_button_colours.mp4
Approach
⭐${\textsf{\color{green}In particular, I'm hoping for some feedback and confirmation on how the logos were included from a licensing perspective.}}$
QA Notes
Here's a quick demo of expected functionality:
Note some of the colours have changed. See the above video for the more up-to-date styling.
select_project_type.mp4