fix import error when matplotlib is not installed #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeM
commented
Apr 16, 2024
| @@ -27,7 +28,6 @@ | |||
| from .data_explorer import DataExplorerService | |||
| from .help import HelpService, help | |||
| from .lsp import LSPService | |||
| from .matplotlib_backend import enable_positron_matplotlib_backend | |||
There was a problem hiding this comment.
The issue was that we were importing matplotlib_backend here, and it was importing matplotlib with no try-catch. The approach in this PR is to never import matplotlib_backend, and only ever let it be imported by matplotlib by setting the MPLBACKEND environment variable. That's the same approach IPython takes with the matplotlib-inline backend.
petetronic
approved these changes
Apr 16, 2024
|
I created a venv, installed ipykernel and was now able to start and use it as a python runtime for Positron without installing matplotlib. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion on Slack: https://positpbc.slack.com/archives/C04FPQK3H9C/p1713294558805659.