Remove Jupyter interactive window config properties #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isabelizimm
reviewed
Apr 17, 2024
| 'jupyter.decorateCells', | ||
| 'jupyter.enableCellCodeLens', | ||
| ]); | ||
| // --- End Positron --- |
There was a problem hiding this comment.
I see a few other configs for the interactive window, all coming from the Jupyter extension. They're not for creating a new window, but if we don't support the interactive window, we might want to drop all mentions of it. I'm not sure if these should stay if they are being used, but noting them here:
jupyter.interactiveWindow.creationMode
jupyter.interactiveWindow.textEditor.autoAddNewCell
jupyter.interactiveWindow.viewColumn
jupyter.interactiveWindow.cellMarker.codeRegex
jupyter.interactiveWindow.codeLens.enableGotoCell
jupyter.interactiveWindow.codeLes.debugCommands (note this is misspelled in the ID, do not fix)
There was a problem hiding this comment.
I had the same question as I was playing with this branch.
There was a problem hiding this comment.
Good point, and ty for listing these. Added in 4f21a36.
isabelizimm
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Address #2144.
Approach
Follows the same approach taken with other Jupyter commands that we block.