Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Explorer: Implement partial state eviction when row filters become invalid for pandas, add error messages, invalid filter state, fix row filter bar state synchronization #2827

Merged
merged 14 commits into from
Apr 22, 2024
Merged

Data Explorer: Implement partial state eviction when row filters become invalid for pandas, add error messages, invalid filter state, fix row filter bar state synchronization #2827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2d1a8a4
Remove discard_state parameter from schema_update frontend
wesm Apr 15, 2024
5bb8a78
New state eviction code minimally working, but needs many more tests
wesm Apr 19, 2024
d5f9db6
Write more schema update/filter test scenarios
wesm Apr 19, 2024
6559ef4
Fix unit test
wesm Apr 19, 2024
172ef2c
Also use Columnschema instead of just index in sort key
wesm Apr 19, 2024
d4224c0
Revert to using column_index in sort keys, workaround change detectio…
wesm Apr 19, 2024
49c9973
Fix compilation, add code to restore filter descriptors from backend …
wesm Apr 19, 2024
777c7cf
Wire up backend state events, not working yet
wesm Apr 20, 2024
2e2a1c8
Fix some rendering, state synchronization issues, add error_message f…
wesm Apr 21, 2024
cf8212f
Fix ruff flakes
wesm Apr 22, 2024
6a767e1
Fix mock unit tests
wesm Apr 22, 2024
6d66c9c
Fix filter button momentarily rendering as invalid until state sync
wesm Apr 22, 2024
58ab073
Make filter valid again when column is restored. Fix theme color name…
wesm Apr 22, 2024
7ae9bd2
Sync sort keys when backend state updated
wesm Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build/lib/stylelint/vscode-known-variables.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,6 +544,7 @@
"--vscode-positronDataExplorer-columnNullPercentGraphBackgroundFill",
"--vscode-positronDataExplorer-columnNullPercentGraphBackgroundStroke",
"--vscode-positronDataExplorer-columnNullPercentGraphIndicatorFill",
"--vscode-positronDataExplorer-invalidFilterBackground",
"--vscode-positronDataExplorer-selectionBackground",
"--vscode-positronDataGrid-background",
"--vscode-positronDataGrid-border",
Expand Down
Loading
Loading