fix improve Run App url matching and fix preview timeout issue #5362
+50
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picks #5336 to bring the fix from the 2024.11 patch branch to the `main` branch. The below description is copied from #5336 and modified to remove the AppUrlString type changes due to conflicts with Prettier. The prerelease branch will need to be updated again to include the additional changes. - #5197 - #5306 - introduces `appUrlStrings` to the run and debug app options, which we will attempt to extract the app url from - the strings should contain the placeholder `{{APP_URL}}`, which indicates the location of the app url relative to the string - adds the appropriate `appUrlStrings` for each framework we support - expands on our url matching by: - attempting to match url-like text where `{{APP_URL}}` is found in the provided `appUrlStrings` - if matching against `appUrlStrings` fails or no `appUrlStrings` are found, we fallback to a more basic url match for strings that start with http or https This PR should also fix a timing issue where the `didPreviewUrlTimeout` would time out before `terminalOutputTimeout`, causing the shell integration warning message to show. We now set `didPreviewUrlTimeout` to be 5 seconds longer than `terminalOutputTimeout`, so that it doesn't timeout before the app preview is done. This PR fixes Run App in Terminal url detection for non-local URLs. One way to get a non-local url is by running the `shiny-py-example` in Positron on Workbench (see #5197). Other app types like Dash, Streamlit, Fastapi, Flask and Gradio should continue to work on Desktop, Server Web and Positron on Workbench. This PR should also fix the issue seen in #5306, which can be tested by running the [Dash Py Example](https://github.com/posit-dev/qa-example-content/tree/main/workspaces/dash-py-example) several times to check that the issue does not occur.
…-run-app-improve-url-matching-additional-fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #5336 to bring in additional fixes from the corresponding PR #5349 on
main.Related issues
Related PRs