Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: use Python Environment Tools for interpreter discovery #5897

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

isabelizimm
Copy link
Contributor

@isabelizimm isabelizimm commented Jan 7, 2025

Release Notes

New Features

Bug Fixes

  • N/A

QA Notes

Should be able to locate interpreters/start up Python runtimes with setting "python.locator": "native"


TODO

  • update development compile commands to automatically set everything up
  • re-enable native locator tests
  • add steps into build CI

Copy link

github-actions bot commented Jan 7, 2025

E2E Tests 🚀  ?
This PR will run tests tagged with: @critical

@@ -689,7 +689,7 @@
"type": "string"
},
"python.locator": {
"default": "js",
"default": "native",
Copy link
Contributor Author

@isabelizimm isabelizimm Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, the rust locator is considered experimental and is opt-in only for upstream. I've swapped it for testing purposes, but we'll want to decide what we want as the default. I've played around with it locally, and it seems to be finding everything and is MUCH FASTER, eg, 1-3 seconds to find my 80+ envs. We should do a bit more robust testing before deciding though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant