-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e-test: new project wizard updates #5908
Conversation
E2E Tests 🚀 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If its passing on all envs, LGTM!
Much more readable now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very satisfying to see all this cleanup 😌 Thank you for doing this!! 🚀
Summary
Revisited the new project wizard tests to simplify them and make them easier to maintain.
Everything seems to be passing now! 🎉 During the process identified a bug and linked it to the Jupyter test.
Also add a new fixture
packages
that enables easy installation of R or Python packages in tests.QA Notes
✅ Ran all touched tests on this PR many times and tests have been solid.
✅ Ran the wizard tests on windows
✅ Ran the r/jupyter wizard tests on browser (previously not tagged for web)
@:new-project-wizard @:r-markdown @:test-explorer @:plots