Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e-test: new project wizard updates #5908

Merged
merged 21 commits into from
Jan 9, 2025
Merged

Conversation

midleman
Copy link
Contributor

@midleman midleman commented Jan 7, 2025

Summary

Revisited the new project wizard tests to simplify them and make them easier to maintain.
Everything seems to be passing now! 🎉 During the process identified a bug and linked it to the Jupyter test.

Also add a new fixture packages that enables easy installation of R or Python packages in tests.

QA Notes

✅ Ran all touched tests on this PR many times and tests have been solid.
✅ Ran the wizard tests on windows
✅ Ran the r/jupyter wizard tests on browser (previously not tagged for web)

@:new-project-wizard @:r-markdown @:test-explorer @:plots

Copy link

github-actions bot commented Jan 7, 2025

E2E Tests 🚀  ?
This PR will run tests tagged with: @critical @new-project-wizard @r-markdown @test-explorer @plots

@midleman midleman marked this pull request as ready for review January 8, 2025 22:23
Copy link
Contributor

@testlabauto testlabauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If its passing on all envs, LGTM!

Much more readable now!

Copy link
Member

@sharon-wang sharon-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very satisfying to see all this cleanup 😌 Thank you for doing this!! 🚀

@midleman midleman merged commit 70064c0 into main Jan 9, 2025
10 of 11 checks passed
@midleman midleman deleted the mi/investiate-new-proj-tests branch January 9, 2025 16:10
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants