-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
settings: Remove settings related to upstream python REPL #5931
Conversation
All contributors have signed the CLA ✍️ ✅ |
E2E Tests 🚀 |
I have read the CLA Document and I hereby sign the CLA |
lint failure is due to #5930 |
There is nothing for us to do to help manage the upstream merges for JSON files, is there? Should we add a note about this to https://connect.posit.it/positron-wiki/overlay-strategy.html? |
In many other JSON files we've added // --- style comments, even if it is not official JSON syntax, the benefit has outweighed the strictness of syntax and those have been tolerated by scripts and applications. We could test it would be tolerated in these particular files to help future merging / code documentation first? If we run into issues, agree we could document it externally as a back up. |
bd7f03e
to
f31b6c8
Compare
Yeah, it turns out that they really don't like comments in
So I won't include the comments in the JSON files, and I'll add a little note in the wiki. |
ah yeah, looks like some tests that change the settings to the non-default value are failing. I suppose I'll remove those tests. |
94a822d
to
e19bb8c
Compare
Okay this should be ready for review! |
@@ -151,7 +148,7 @@ | |||
"walkthrough.step.python.createEnvironment.title": "Select or create a Python environment", | |||
"walkthrough.step.python.createEnvironment.description": { | |||
"message": "Create an environment for your Python project or use [Select Python Interpreter](command:python.setInterpreter) to select an existing one.\n[Create Environment](command:python.createEnvironment)\n**Tip**: Run the ``Python: Create Environment`` command in the [Command Palette](command:workbench.action.showCommands).", | |||
"comment": [ | |||
"comment": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some funky formatting inconsistencies between positron
and the positron-python
(that hopefully should be resolved soon with #5838) that can result in this weirdness via format-on-save 😩
Are you able to remove these unrelated whitespace changes? I believe the easiest way is to command palette Format Document
from inside the extensions/positron-python
workspace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! I originally kept them because they seemed like improvements, but I can remove them from this PR since they're unrelated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see, we inherited the weirdness from the upstream. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I also tried it out locally and could not sniff out any non-Positron REPL settings 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
This PR removes the
python.REPL.*
settings that come from the upstream, which aren't useful in Positron since we don't use the python REPL.Release Notes
New Features
Bug Fixes
QA Notes
I validated that these settings don't appear in the settings menu anymore.