Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metric defined twice, causing error in many exercises #59

Closed
garrettgman opened this issue Jul 8, 2024 · 0 comments · Fixed by #63
Closed

metric defined twice, causing error in many exercises #59

garrettgman opened this issue Jul 8, 2024 · 0 comments · Fixed by #63
Assignees
@garrettgman
Labels
needs-triage

Comments

@garrettgman
Copy link
Collaborator

Many of the exercises define both a function named metric() as well as an input named metric. As a result, a Shiny Client Error pop up appears when you run the problem code or the solution code (pictured below).

This bug was inherited by the Talk Python to Me course.

Screenshot 2024-07-08 at 1 57 54 PM
@garrettgman garrettgman self-assigned this Jul 8, 2024
@garrettgman garrettgman mentioned this issue Jul 8, 2024
Merged
garrettgman added a commit that referenced this issue Jul 9, 2024
@garrettgman
Merge pull request #63 from posit-dev/metric-fix
ad31db3 
Fixes #59. Naming conflict in metric()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garrettgman garrettgman

Labels
needs-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #59. Naming conflict in metric() posit-dev/py-shiny-workshop
1 participant
@garrettgman