Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readcomiconline.li issue #84

Open
1 of 4 tasks
Teofil98 opened this issue Jul 1, 2024 · 2 comments
Open
1 of 4 tasks

Readcomiconline.li issue #84

Teofil98 opened this issue Jul 1, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Teofil98
Copy link

Teofil98 commented Jul 1, 2024

What broke?

  • Downloader
  • Processor
  • Converter
  • Other

Mandown version
Output of mandown --version: mandown 1.9.0

Describe the bug
A clear and concise description of what the bug is.

The following error appears when trying to download a comic from readcomiconline.li

Traceback (most recent call last):

  File "/usr/bin/mandown", line 8, in <module>
    sys.exit(main())
             ^^^^^^

  File "/usr/lib/python3.12/site-packages/mandown/cli.py", line 550, in main
    app()

  File "/usr/lib/python3.12/site-packages/mandown/cli.py", line 428, in get
    for title in progress:

  File "/usr/lib/python3.12/site-packages/mandown/api.py", line 277, in download_progress
    image_urls = comic.get_chapter_image_urls(chap)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "/usr/lib/python3.12/site-packages/mandown/comic.py", line 47, in get_chapter_image_urls
    return self.source.fetch_chapter_image_list(chapter)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "/usr/lib/python3.12/site-packages/mandown/sources/source_readcomiconline.py", line 71, in fetch_chapter_image_list
    images.append(self.beau(text[s_index:e_index]))
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "/usr/lib/python3.12/site-packages/mandown/sources/source_readcomiconline.py", line 110, in beau
    url = binascii.a2b_base64(url).decode()
          ^^^^^^^^^^^^^^^^^^^^^^^^

binascii.Error: Invalid base64-encoded string: number of data characters (137) cannot be 1 more than a multiple of 4


Steps to reproduce
If the downloader broke, please include a URL that breaks it.

mandown get https://readcomiconline.li/Comic/Batman-Year-One

Additional context
Add any other context about the problem here.

@Teofil98 Teofil98 added the bug Something isn't working label Jul 1, 2024
@potatoeggy
Copy link
Owner

Thanks for opening an issue!

If you open the comic URL in your browser, do you get a Cloudflare captcha? If so, unfortunately, Mandown won't be able to download the comic because it can't bypass Cloudflare's anti-bot protection.

@Teofil98
Copy link
Author

Teofil98 commented Jul 4, 2024

Hi, thanks for the reply!

No, I don't get a captcha when opening the URL in a browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants