Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bloom filters #7

Open
simonacca opened this issue Jun 1, 2016 · 3 comments
Open

Bloom filters #7

simonacca opened this issue Jun 1, 2016 · 3 comments

Comments

@simonacca
Copy link

I just discovered this plugin and I very much like it!
Although I am not really keen on sending all the URLs I visit to algolia or other services.

How are you on the idea of using a bloom filter with all hn stories urls, so that the pages the user visits are tested locally for presence in HN, and algolia is contacted only when the test is positive?

@huyz
Copy link

huyz commented Jun 1, 2016

I was under the impression that URLs were only sent when you pressed the browser icon.

@simonacca
Copy link
Author

How can that be, given that the sidebar toggle button is displayed only when the page visited is on HN?

@huyz
Copy link

huyz commented Jun 1, 2016

Oh that's right, I forgot that I had forked this repo and modified it exactly because I had the same fears as you. I added a browser bar icon and I only search on demand. See https://github.com/huyz/hn-sidebar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants