[Flow decomposition] Fix net position computation with dangling lines #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hugo SCHINDLER <hugo.schindler@rte-france.com>
Signed-off-by: Hugo SCHINDLER <hugo.schindler@rte-france.com>
OpenSuze
added
PR: waiting-for-review
bug
Signed-off-by: Hugo SCHINDLER <hugo.schindler@rte-france.com>
OpenSuze
force-pushed
the
feature/fix_net_position_in_flow_decomposition
branch
2 times, most recently
from
8ea6e60 to
8b7c940
Compare
Signed-off-by: Hugo SCHINDLER <hugo.schindler@rte-france.com>
OpenSuze
force-pushed
the
feature/fix_net_position_in_flow_decomposition
branch
from
8b7c940 to
bc8bda0
Compare
|
phiedw
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
The flow decomposition was wrong when a network had some dangling lines.
This is caused by a bug in the net position computation.
What kind of change does this PR introduce?
We fixed the net position computation with dangling line.
A test has been added.
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
None
Other information:
Previous results of flow decomposition on network with dangling lines are wrong.