Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flow decomposition] Observer, NetworkUtil and Losses compensator improvements #147

Merged
merged 1 commit into from
Jun 6, 2024
Merged

[Flow decomposition] Observer, NetworkUtil and Losses compensator improvements #147

merged 1 commit into from
Jun 6, 2024

Conversation

caioluke
Copy link
Member

@caioluke caioluke commented May 27, 2024 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Feature

What is the current behavior?

  • Docs lacking
  • Refactoring for observers in flow decompostion computer and NetworkUtils
  • Losses compensator
    • We don't compensate losses for branches that are connected to only one side
    • Bug in edge case where both P1 and P2 are positive (one is really close to zero) and the sending terminal is incorrectly identified
    • Set loads created to compensate losses to fictitious (will make a difference when Avoid slack distribution to fictitious loads powsybl-open-loadflow#1028 is merged)

What is the new behavior (if this is a feature change)?

  • Docs added
  • Issue created [Flow decomposition]  #150
  • Refactored observers in flow decompostion computer and NetworkUtils
  • Losses compensator
    • Compensate losses for branches connected to only one side
    • Sending terminal is always correctly identified
    • Slack won't be distributed on fictitious loads created by losses compensator

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

@caioluke caioluke requested a review from OpenSuze May 27, 2024 10:08
@caioluke caioluke self-assigned this May 27, 2024
@OpenSuze OpenSuze mentioned this pull request May 30, 2024
Merged
5 tasks
@caioluke caioluke changed the title Losses compensator improvements [Flow decomposition] Observer, NetworkUtil and Losses compensator improvements Jun 3, 2024
@OpenSuze OpenSuze force-pushed the losses_compensator_improvements branch from 81d253e to 8b638fa Compare June 4, 2024 08:55
@OpenSuze
Copy link
Contributor

OpenSuze commented Jun 4, 2024

I have force pushed to fix the DCO.

@caioluke
[Flow decomposition] Observer, NetworkUtil and Losses compensator imp…
d46aac8 
…rovements

Signed-off-by: Caio Luke <caioluke97@gmail.com>
@caioluke caioluke force-pushed the losses_compensator_improvements branch from 07b7697 to d46aac8 Compare June 6, 2024 10:21
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@phiedw phiedw merged commit 799f478 into main Jun 6, 2024
7 checks passed
@phiedw phiedw deleted the losses_compensator_improvements branch June 6, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OpenSuze OpenSuze OpenSuze approved these changes

@phiedw phiedw phiedw approved these changes

Assignees

@caioluke caioluke

Labels
PR: waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caioluke @OpenSuze @phiedw