Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Remove create contingencies menu item #278

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

nashousni
Copy link
Contributor

@nashousni nashousni commented Feb 25, 2020

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • [x ] The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
no

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature

What is the new behavior (if this is a feature change)?
The "Create contingencies " menu item can be removed by the user by setting the config file visible property to false:
example :

contingency-creator-extension-menu:
visible: false

Does this PR introduce a breaking change or deprecate an API? If yes, check the following:

  • The Breaking Change or Deprecated label has been added
  • The migration guide has been updated in the github wiki (What changes might users need to make in their application due to this PR?)
    no breaking change

Other information:

(if any of the questions/checkboxes don't apply, please delete them entirely)

Nassirou NAMBIEMA added 2 commits February 24, 2020 17:02
Signed-off-by: Nassirou NAMBIEMA <nassirou.nambiena@rte-france.com>
…t to false

Signed-off-by: Nassirou NAMBIEMA <nassirou.nambiena@rte-france.com>
@nashousni nashousni changed the title Nan/remove create contingencies menu item Remove create contingencies menu item Feb 25, 2020
Signed-off-by: Nassirou NAMBIEMA <nassirou.nambiena@rte-france.com>
Copy link
Contributor

@pl-buiquang pl-buiquang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The black/whitelisting of extension should be external to the extension definition.

@nashousni nashousni changed the title Remove create contingencies menu item [WIP] Remove create contingencies menu item Feb 27, 2020
Nassirou NAMBIEMA added 4 commits February 27, 2020 11:46
Signed-off-by: Nassirou NAMBIEMA <nassirou.nambiena@rte-france.com>
Signed-off-by: Nassirou NAMBIEMA <nassirou.nambiena@rte-france.com>
Signed-off-by: Nassirou NAMBIEMA <nassirou.nambiena@rte-france.com>
Signed-off-by: Nassirou NAMBIEMA <nassirou.nambiena@rte-france.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Signed-off-by: Nassirou NAMBIEMA <nassirou.nambiena@rte-france.com>
@nashousni nashousni changed the title [WIP] Remove create contingencies menu item Remove create contingencies menu item Feb 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants