add regulating point for transformers #479
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinebhs
reviewed
Dec 2, 2024
...store-model/src/main/java/com/powsybl/network/store/model/RegulatingEquipmentIdentifier.java
Show resolved
Hide resolved
...re-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/InjectionRegulatingPoint.java
Outdated
Show resolved
Hide resolved
network-store-model/src/main/java/com/powsybl/network/store/model/ResourceType.java
Outdated
Show resolved
Hide resolved
network-store-model/src/main/java/com/powsybl/network/store/model/ResourceDeserializer.java
Outdated
Show resolved
Hide resolved
...re-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/CachedNetworkStoreClient.java
Outdated
Show resolved
Hide resolved
...-iidm-impl/src/test/java/com/powsybl/network/store/iidm/impl/TwoWindingsTransformerTest.java
Outdated
Show resolved
Hide resolved
...-iidm-impl/src/test/java/com/powsybl/network/store/iidm/impl/TwoWindingsTransformerTest.java
Outdated
Show resolved
Hide resolved
...-iidm-impl/src/test/java/com/powsybl/network/store/iidm/impl/TwoWindingsTransformerTest.java
Show resolved
Hide resolved
...e-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/TapChangerRegulatingPoint.java
Outdated
Show resolved
Hide resolved
...e-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/TapChangerRegulatingPoint.java
Outdated
Show resolved
Hide resolved
EtienneLt
force-pushed
the
add-regulating-point-for-transformers
branch
from
a7c9927 to
a9562d3
Compare
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
EtienneLt
force-pushed
the
add-regulating-point-for-transformers
branch
from
8ccff89 to
1217fdd
Compare
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
|
Fix sonar issues |
antoinebhs
reviewed
Dec 11, 2024
...ore-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/AbstractRegulatingPoint.java
Show resolved
Hide resolved
Comment on lines
+49
to
+51
| // for three windings transformer the local side will be the leg number | ||
| // for two windings transformer the ratio is regulating on side 2 | ||
| ThreeSides side = ThreeSides.TWO; |
There was a problem hiding this comment.
still not sure where does this come from?
...ore-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/AbstractRegulatingPoint.java
Outdated
Show resolved
Hide resolved
...ork-store-iidm-impl/src/test/java/com/powsybl/network/store/iidm/impl/tck/GeneratorTest.java
Outdated
Show resolved
Hide resolved
...ork-store-model/src/main/java/com/powsybl/network/store/model/RegulatingPointAttributes.java
Outdated
Show resolved
Hide resolved
network-store-model/src/main/java/com/powsybl/network/store/model/RegulatingTapChangerType.java
Outdated
Show resolved
Hide resolved
network-store-model/src/main/java/com/powsybl/network/store/model/RegulatingTapChangerType.java
Outdated
Show resolved
Hide resolved
...e-iidm-impl/src/main/java/com/powsybl/network/store/iidm/impl/TapChangerRegulatingPoint.java
Outdated
Show resolved
Hide resolved
network-store-model/src/test/java/com/powsybl/network/store/model/TopLevelDocumentTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
|
My last comment is that I'm not sure why we hard code: |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
no
What kind of change does this PR introduce?
it is a new feature and a bug fix
What is the current behavior?
when ratio tap changer and phase tap changer for 2 and 3 windings transformers regulate in remote,
if the regulated equipment is deleted they still regulate on the deleted element.
What is the new behavior (if this is a feature change)?
add regulating point for 2 and 3 windings transformers
Does this PR introduce a breaking change or deprecate an API?
Other information:
The list of regulating equipments in the equipment that can be regulated change from
to
where is a class containing String, ResourceType because RatioTapChanger and PhaseTapChanger regulating point have the same regulatingEquipment id which is the transformerId and can not be distinguished with the map if they regulate the same equipment