Fix NAD branch width when zooming in Microsoft Edge #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seddik Yengui <seddik.yengui@rte-france.com>
Signed-off-by: Seddik Yengui <seddik.yengui@rte-france.com>
Signed-off-by: Seddik Yengui <seddik.yengui@rte-france.com>
Signed-off-by: Seddik Yengui <seddik.yengui@rte-france.com>
Signed-off-by: Seddik Yengui <seddik.yengui_externe@rte-france.com>
YenguiSeddik
changed the title
klesaulnier
reviewed
Nov 18, 2024
| @@ -9,77 +9,67 @@ export enum THRESHOLD_STATUS { | |||
| BELOW = 'BELOW', | |||
| ABOVE = 'ABOVE', | |||
| } | |||
| export type CSS_DECLARATION = Record<string, string>; | |||
|
|
|||
| export type CSS_DECLARATION = Record<string, (value: number) => string>; | |||
There was a problem hiding this comment.
Suggested change
| export type CSS_DECLARATION = Record<string, (value: number) => string>; | |
| export type CSS_DECLARATION = Record<string, ((value: number) => string) | string>; |
then use CSS_DECLARATION instead of Record<string, string> ?
There was a problem hiding this comment.
For updateSvgCssDisplayValue function, the type should be Record<string, string> or we have to consider both cases of string and (value: number) => string.
Instead, I kept the old CSS_DECLERATION type as Record<string, string> and added a new type DYNAMIC_CSS_DECLARATION = Record<string, ((value: number) => string) | string>; which gives the user the freedom to use a function or a value
Signed-off-by: Seddik Yengui <seddik.yengui_externe@rte-france.com>
Signed-off-by: Seddik Yengui <seddik.yengui_externe@rte-france.com>
EstherDarkish
requested changes
Nov 22, 2024
src/components/network-area-diagram-viewer/dynamic-css-utils.ts
Outdated
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
Comment on lines
1409
to
1414
| 'CSS Rule ' + | ||
| rule.cssSelector + | ||
| ' above threshold ' + | ||
| maxDisplayedSize + | ||
| ' >= ' + | ||
| rule.threshold |
There was a problem hiding this comment.
Same thing, we should remove this log.
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
added 4 commits
November 25, 2024 03:43
Signed-off-by: Seddik Yengui <seddik.yengui_externe@rte-france.com>
Signed-off-by: Seddik Yengui <seddik.yengui_externe@rte-france.com>
Signed-off-by: Seddik Yengui <seddik.yengui_externe@rte-france.com>
Signed-off-by: Seddik Yengui <seddik.yengui_externe@rte-france.com>
Signed-off-by: Seddik Yengui <seddik.yengui_externe@rte-france.com>
…sybl-diagram-viewer into fix_nad_branch_edges Signed-off-by: Seddik Yengui <seddik.yengui_externe@rte-france.com>
|
|
Another solution was merged. This is now obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Bug Fix: When using Microsoft Edge, CSS rules for branch width do not apply when zooming in NAD. The behivior. the behavior is fixed at the slightest movement of the svg, but when zooming without moving the svg, the width of the branches does not change dynamically as expected
Does this PR introduce a breaking change or deprecate an API?