Don't update dynamiccssrules on panning, add chromium percentage missing redraw workaround #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Show resolved
Hide resolved
src/components/network-area-diagram-viewer/network-area-diagram-viewer.ts
Outdated
Show resolved
Hide resolved
jonenst
changed the title
jonenst
changed the title
YenguiSeddik
approved these changes
Dec 13, 2024
Signed-off-by: HARPER Jon <jon.harper87@gmail.com>
This allows to see the effect of the workarounds for the css containing percent in the demo. And it's generally useful to have this kind of css when enabling level of detail Signed-off-by: HARPER Jon <jon.harper87@gmail.com>
Signed-off-by: HARPER Jon <jon.harper87@gmail.com>
jonenst
force-pushed
the
fixsvgpercentwhenzoom
branch
from
912cebd to
52cdd79
Compare
|
EstherDarkish
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
NO
What kind of change does this PR introduce?
feature/bugfix
What is the current behavior?
css rules are updated when the viewbox changes, even for translations. But we only use the zoom level in rules
Also, chromium doesn't update the rendering when of percents (stroke-width), so add a workaround to force redraw
when the zoom changes by 1 percent
What is the new behavior (if this is a feature change)?
no update of rules during translations. Chromium redraw on zoom workaround (enabled all the time for consistency)
Does this PR introduce a breaking change or deprecate an API?
Other information:
we could split this PR in 2. We could enable the workaround only if we detect dynamic rules with percentages