Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to deck.gl v9 and typescript, add 2 packages dependancies network-map-layers and single-line-diagram-viewer #91

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

amarant
Copy link
Contributor

@amarant amarant commented Jul 26, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

This PR does several changes :

  • update the map and layers to deck.gl v9
  • update the shaders to WebGL 2 and GLSL ES 3.00
  • move all files to typescript
  • tries to infer the types the best I could, but it is probably not perfect as it is.
  • move the deck.gl layers to a workspace package network-map-layers that only depends on minimal dependencies
  • move the svg utilities to another package single-line-diagram-viewer
  • the main package depends on those two package but it doesn't change its behavior nor exports.

What is the current behavior?

Currently the package is monolithic, and have dependencies on react, mui, mapbox, maplibre when a project might want to not use react and use instead the vanilla JS deck.gl api, use another ui toolkit than mui, or don't use mapbox or maplibre at all.

What is the new behavior (if this is a feature change)?

Separated package dependencies so that an user can import directly the deck.gl layer it wants and integrates deck.gl the way it wants.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

No API change but using deck.gl V9 might be seen as a breaking change, also it no longer support WebGL v1
WebGL v2 support is now old : 2017 for Chrome/Firefox and 2021 for Safari
Support corresponds to OpenGL ES 3.0, GeForce 400 + and Radeon HD 5000 + released around 2010/2011.

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Update their old graphic card or driver to one that support WebGL v2.

Other information:

This work started a few weeks ago, so it doesn't includes the all the changes after 2024/07/08, but I migrated the typescript definitions after that.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants