Contingency Load Flow parameters extension #1139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmouradian
force-pushed
the
feature/contingency-parameters-extension
branch
from
09be168 to
dec6e7c
Compare
vmouradian
changed the title
jeandemanged
changed the title
m-guibert
reviewed
Dec 5, 2024
src/main/java/com/powsybl/openloadflow/sa/ContingencyParameters.java
Outdated
Show resolved
Hide resolved
vmouradian
changed the title
jeandemanged
requested changes
Dec 16, 2024
There was a problem hiding this comment.
move to a new package com.powsybl.openloadflow.sa.extensions
src/main/java/com/powsybl/openloadflow/sa/ContingencyParameters.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
move to a new package com.powsybl.openloadflow.sa.extensions
There was a problem hiding this comment.
move the new tests to subpackage com.powsybl.openloadflow.sa.extensions
There was a problem hiding this comment.
not sure this class is really useful, just put this code inside the test, also the naming is confusing, JsonSerializer is generic but we can see it is tailored to ContingencyJsonModule. Have a look how it is done in ContingencyJsonTest in powsybl-core.
jeandemanged
changed the title
m-guibert
reviewed
Dec 16, 2024
src/main/java/com/powsybl/openloadflow/sa/ContingencyParametersJsonSerializer.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisProviderTest.java
Outdated
Show resolved
Hide resolved
7 tasks
vmouradian
force-pushed
the
feature/contingency-parameters-extension
branch
from
d47e484 to
69fe35c
Compare
vmouradian
changed the base branch from
main
to
feature/refactor-outer-loops
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
vmouradian
force-pushed
the
feature/contingency-parameters-extension
branch
from
69fe35c to
5a6aa8d
Compare
m-guibert
reviewed
Dec 20, 2024
src/main/java/com/powsybl/openloadflow/sa/extensions/ContingencyLoadFlowParameters.java
Outdated
Show resolved
Hide resolved
...java/com/powsybl/openloadflow/sa/extensions/ContingencyLoadFlowParametersJsonSerializer.java
Show resolved
Hide resolved
...java/com/powsybl/openloadflow/sa/extensions/ContingencyLoadFlowParametersJsonSerializer.java
Show resolved
Hide resolved
...java/com/powsybl/openloadflow/sa/extensions/ContingencyLoadFlowParametersJsonSerializer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: vmouradian <valentin.mouradian@artelys.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Creates the class needed for #1091
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: