Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cnec reliability margin #1024

Closed
wants to merge 13 commits into from

Conversation

bqth29
Copy link
Collaborator

@bqth29 bqth29 commented May 28, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
Fixes #1011

bqth29 added 10 commits May 22, 2024 16:05
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@MartinBelthle MartinBelthle force-pushed the cleaning/remove_cnec_reliability_margin branch from 6ee59e0 to c7c8480 Compare May 28, 2024 12:24
@bqth29 bqth29 added cleaning This issue or pull request only concerns improving the overall state of the code breaking-change Changes could break users' code labels Jun 17, 2024
bqth29 added 3 commits June 26, 2024 09:39
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
# Conflicts:
#	data/crac-io/crac-io-json/src/test/java/com/powsybl/openrao/data/craciojson/JsonRetrocompatibilityTest.java
#	data/crac/crac-impl/src/test/java/com/powsybl/openrao/data/cracimpl/OnVoltageConstraintAdderImplTest.java
#	data/crac/crac-impl/src/test/java/com/powsybl/openrao/data/cracimpl/utils/ExhaustiveCracCreation.java
Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@pet-mit
Copy link
Collaborator

pet-mit commented Aug 6, 2024

@bqth29 what's the status on this PR?

@bqth29 bqth29 closed this Sep 18, 2024
@bqth29
Copy link
Collaborator Author

bqth29 commented Sep 18, 2024

@bqth29 what's the status on this PR?

Too many conflicts, I chose to close it and opened a new one (#1138) instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes could break users' code cleaning This issue or pull request only concerns improving the overall state of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove CNEC reliability margin
2 participants