Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace PrePerimeterResult by record #1252

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bqth29
Copy link
Collaborator

@bqth29 bqth29 commented Jan 2, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

What kind of change does this PR introduce?
The PrePerimeterResult interface was converted to a record as it is more relevant and less confusing to use it that way.

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: Thomas Bouquet <thomas.bouquet@rte-france.com>
@bqth29 bqth29 added cleaning This issue or pull request only concerns improving the overall state of the code PR: waiting-for-review This PR is waiting to be reviewed labels Jan 2, 2025
@bqth29 bqth29 requested review from phiedw, pet-mit and Godelaine and removed request for phiedw January 2, 2025 10:35
@bqth29
Copy link
Collaborator Author

bqth29 commented Jan 2, 2025

Carry the same work for OptimizationResult, LinearOptimizationResult and RemedialActionActivationResult

@pet-mit
Copy link
Collaborator

pet-mit commented Jan 3, 2025

I'm not convinced by the motivation behind this PR. It seems to me that these changes defeat the purpose of having interfaces that hide implementation details, and will paradoxically make PrePerimeterResult harder to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning This issue or pull request only concerns improving the overall state of the code PR: waiting-for-review This PR is waiting to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants