Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize NAD based on geographical data #106

Closed
wants to merge 4 commits into from

Conversation

souissimai
Copy link
Contributor

@souissimai souissimai commented Aug 9, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

NO

What kind of change does this PR introduce?

Feature

What is the current behavior?

By default, NAD is initialized with geographical data.

What is the new behavior (if this is a feature change)?
Add a parameter to allow the choice of initializing NAD with or without geographical data.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
@souissimai souissimai requested review from jamal-khey and removed request for jamal-khey August 9, 2024 11:25
@klesaulnier klesaulnier self-requested a review August 13, 2024 09:26
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
Signed-off-by: maissa SOUISSI <maissa.souissi@rte-france.com>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@souissimai souissimai closed this Aug 16, 2024
@souissimai souissimai deleted the initialize_NAD_based_on_Geographical_data branch August 16, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant