Add a metric for diagram generations in the thread pool #131
Conversation
SlimaneAmar
force-pushed
the
monitoring-execution-queue
branch
2 times, most recently
from
274d483 to
6e3e4f3
Compare
SlimaneAmar
force-pushed
the
monitoring-execution-queue
branch
from
6e3e4f3 to
46852fa
Compare
Signed-off-by: Slimane AMAR <amarsli@gm0winl104.bureau.si.interne>
SlimaneAmar
force-pushed
the
monitoring-execution-queue
branch
from
46852fa to
a6181a1
Compare
| * @author Slimane Amar <slimane.amar at rte-france.com> | ||
| */ | ||
| @Service | ||
| public class DiagramGenerationExecutionService { |
There was a problem hiding this comment.
Maybe NetworkAreaExecutionService as it's not used for the SLD?
| MultiGauge multiGauge = MultiGauge.builder(TASK_POOL_METER_NAME).description("The number of diagram generations (tasks) in the thread pool").register(meterRegistry); | ||
| multiGauge.register(List.of( | ||
| MultiGauge.Row.of(Tags.of(TASK_TYPE_TAG_NAME, TASK_TYPE_TAG_VALUE_CURRENT), threadPoolExecutor::getActiveCount), | ||
| MultiGauge.Row.of(Tags.of(TASK_TYPE_TAG_NAME, TASK_TYPE_TAG_VALUE_PENDING), () -> threadPoolExecutor.getQueue().size()) | ||
| )); |
There was a problem hiding this comment.
I'm not sure to understand why we need a multigauge here as the number of tags is constant and equal to 2. From my understanding multigauge are useful if the number of tags vary.
Here, it seems simpler to have two gauges (one for current, one for pending)?
There was a problem hiding this comment.
Wiith Jauge.builder we can't have a value supplier different for different tags !
|
|
||
| @Autowired | ||
| private SingleLineDiagramService singleLineDiagramService; | ||
| private final DiagramGenerationExecutionService diagramExecutionService; |
There was a problem hiding this comment.
why inject this here and not in the service directly ?
Move diagramExecutionService in NetworkAreaDiagramService.java?
| return diagramExecutionService | ||
| .supplyAsync(() -> networkAreaDiagramService.getNetworkAreaDiagramSvg(networkUuid, variantId, voltageLevelsIds, depth, withGeoData)) | ||
| .get(); |
There was a problem hiding this comment.
this could simplify to
| return diagramExecutionService | |
| .supplyAsync(() -> networkAreaDiagramService.getNetworkAreaDiagramSvg(networkUuid, variantId, voltageLevelsIds, depth, withGeoData)) | |
| .get(); | |
| return networkAreaDiagramService.getNetworkAreaDiagramSvg(networkUuid, variantId, voltageLevelsIds, depth, withGeoData)); |
?
There was a problem hiding this comment.
If we want it to be used for SLD and NAD, it makes sense to have it here. But from the code, it looks specialized to NAD.
SlimaneAmar
force-pushed
the
monitoring-execution-queue
branch
2 times, most recently
from
68a392f to
22916da
Compare
SlimaneAmar
force-pushed
the
monitoring-execution-queue
branch
from
22916da to
3924027
Compare
|
No description provided.