Add computation utility class #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nResultUtils class - Added a new dependency for powsybl-security-analysis-api version 6.4.1 in pom.xml. - Created ComputationResultUtils class to handle violation location identification and formatting for network computations. Signed-off-by: jamal-khey <myjamal89@gmail.com>
…introduce ComputationUtilTest class - Created ComputationUtilTest class to implement unit tests for ComputationResultUtils, covering various scenarios for formatting node IDs and handling violation locations. Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
SlimaneAmar
reviewed
Dec 3, 2024
pom.xml
Outdated
| @@ -163,5 +170,11 @@ | |||
| <artifactId>spring-boot-starter-test</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
i removed this dependency
Signed-off-by: jamal-khey <myjamal89@gmail.com>
jamal-khey
force-pushed
the
jamal-khey/add-computation-result-utilities
branch
from
5e65c3d to
422f02e
Compare
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
SlimaneAmar
force-pushed
the
jamal-khey/add-computation-result-utilities
branch
from
10338a0 to
24eda64
Compare
Signed-off-by: jamal-khey <myjamal89@gmail.com>
SlimaneAmar
reviewed
Dec 5, 2024
| .setId("NGEN2") | ||
| .add(); | ||
|
|
||
| when(busBreakerViolationLocation.getBusView(any())).thenReturn(() -> Stream.of(ngen, ngen2)); |
There was a problem hiding this comment.
ngen2 is a configured bus and not a calculated bus !
SlimaneAmar
force-pushed
the
jamal-khey/add-computation-result-utilities
branch
from
57d99cd to
4833476
Compare
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
SlimaneAmar
approved these changes
Dec 5, 2024
jamal-khey
requested review from
flo-dup and
EtienneLt
and removed request for
flo-dup
EtienneLt
reviewed
Dec 5, 2024
src/test/java/com/powsybl/ws/commons/computation/ComputationUtilTest.java
Show resolved
Hide resolved
EtienneLt
reviewed
Dec 5, 2024
src/main/java/com/powsybl/ws/commons/computation/utils/ComputationResultUtils.java
Show resolved
Hide resolved
Signed-off-by: jamal-khey <myjamal89@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: