Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard and soft voting for predict of EnsembleMODNetModel #245

Merged
merged 4 commits into from
Jan 8, 2025

Conversation

kaueltzen
Copy link
Contributor

@kaueltzen kaueltzen commented Nov 21, 2024

Resolves #225 .

  • implemented hard and soft voting option for prediction of ensemble classifiers in case of predict_prob=False
  • added test for multi target classification ensemble, adapted test of single target classification ensemble

@ppdebreuck let me know if you need anything else(:

Also I want to note that with the current changes, the shapes of df_mean and df_std differ for soft voting (df_std contains stds on class probability predictions, df_mean integer class labels), but I don't know if anything else would make more sense.

@kaueltzen kaueltzen marked this pull request as ready for review November 22, 2024 10:44
@ppdebreuck ppdebreuck requested a review from VicTrqt December 18, 2024 11:11
@ppdebreuck ppdebreuck merged commit 0bb2000 into ppdebreuck:master Jan 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

predict method of EnsembleMODNetModel does not correspond to majority vote for classification tasks
2 participants