Some docker improvements #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll use these files in the build process but will not copy them into the containter.
…when changes are made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Dockerfile and .dockerignore files to the .dockerignore file. These files will still be sent to the Docker daemon, but the ADD and COPY directives won't add them to the container.
With docker-compose, you can run
docker-compose up --build -dand any service defined with abuildconfiguration option will be rebuilt before the container are restarted. NB - containers are only restarted if they need to be.I would also recommend pulling your Nginx configuration into an Alpine based Nginx container and mapping in the certificates using docker volumes or secrets. I'd be happy to help with this if it would be beneficial.